Hi Dries, There's no real reason why ResourceFileSet is sealed, so I'll change that.
Gert -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Dries Samyn Sent: woensdag 28 november 2007 22:42 To: nant-developers@lists.sourceforge.net Cc: Mark Reid Subject: [nant-dev] Sealed ResourceFileSet and Xml File attribute Hi, We are working on an open source project, a tool to aid the build/test/documentation process. This will come in the form of a set of nAnt templates packaged up with the required binaries (nAnt, nUnit, nCover, nCoverExplorer ...) to provide a "one click" solution. Anyway, as party of our solution, we wanted to provide a non-intrusive and optional way of integrating with visual studio project files. We achieved this by implementing a BluePrintFileset task that supports a XmlInclude element. This allows you to pass an XPath expression (and optionally a path xslt file to transform the xml file before applying the XPath expression). This allows something like this in the nAnt file: <blueprintfileset id="sources"> <xmlinclude src="${path.src.project.csproj}" xpath="/ns:Project/ns:ItemGroup/ns:Compile/@Include"> <namespaces> <namespace prefix="ns" uri="http://schemas.microsoft.com/developer/msbuild/2003"; /> </namespaces> </xmlinclude> </blueprintfileset> And this can be used in the compile task. This works very well so far, but we have one issue. We realised later on the ResourceFileset is a specialised type. So we thought of refactoring our code to also provide a special case of this. However, we noticed this class is sealed. We changed this and re-compiled and tested our solution and all seems to work. So we have a couple of questions. Firstly, is there any reason why this class is sealed? Secondly, we would obviously prefer to not have to use a "bespoke" version of nAnt. So would there be any way we could commit this change if there would be no specific reason for this to be sealed? Or, is there any scope to add the XmlInclude element to the standard Fileset? It may be generally quite useful functionality? I tried to attached a copy of the task for reference, but the email didn't get through, so if anybody wants a copy, let me know and I'll email it or upload it somewhere. Dries. ------------------------------------------------------------------------- SF.Net email is sponsored by: The Future of Linux Business White Paper from Novell. From the desktop to the data center, Linux is going mainstream. Let it simplify your IT future. http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4 _______________________________________________ nant-developers mailing list nant-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nant-developers ------------------------------------------------------------------------- SF.Net email is sponsored by: The Future of Linux Business White Paper from Novell. From the desktop to the data center, Linux is going mainstream. Let it simplify your IT future. http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4 _______________________________________________ nant-developers mailing list nant-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nant-developers
