Hajo,

I wanted to create SvnExportTask that will perform svn export command.
The fastest way to do it was to create new class and inherit from SvnCheckoutTask. svn checkout and svn export have almost identical syntax. Try to imagine that this obvious solution does not work.
Why? Because of AbstractSvnTask.IsRootUsed has following body:


 private bool IsRootUsed {
 get
 {
    if (this.CommandName.IndexOf("co") > -1 ||
        this.CommandName.IndexOf("checkout") > -1 ||
    {
       return true;
    }
    return false;
 }
}

I think that hardcoded name of command is not good idea.
I suggest to do the IsRootUsed a virtual property that will
be overriden in SvnCheckoutTask. I took me about 3 hours to find
this "hidden" condition.

What do you think about it?

gawel








-------------------------------------------------------
This Newsletter Sponsored by: Macrovision For reliable Linux application installations, use the industry's leading
setup authoring tool, InstallShield X. Learn more and evaluate today. http://clk.atdmt.com/MSI/go/ins0030000001msi/direct/01/
_______________________________________________
NAntContrib-Developer mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/nantcontrib-developer

Reply via email to