Sounds like your fix is more well-thought out and useful than mine. It should be used instead. The major issue I have with what is in the code right now is assigning values to the AppRoot attribute, the behaviour of iis when this is done is not documented afaik, so using it in this way should be avoided.
Kevin On Thu, 25 Nov 2004 11:44:15 +0100, Rutger Dijkstra <[EMAIL PROTECTED]> wrote: > Two remarks about this fix: > 1.) 'AppCreate(true)' will create an in-process application. > Not recommend as a default. (potentially hazardous) > 2.) The default value for the appcreate attribute is 'false', > meaning that no application is created. A logical choice, > but it will probably break most existing uses of the task. > (deploy a web-app and run some tests against it) > > I have submitted a version of the iis-tasks that take care > of some other bugs. I could add the 'appcreate' attribute > with possible values of 'none', 'inproc', 'pooled', and > 'outofproc' (where 'pooled' = 'outofproc' on iis4 since it > does not support 'pooled'). > The most logical default would be 'none' but if we want to > avoid breaking existing scripts the most responsible default > would be 'pooled' (which i use in my fix). > > cheers, rutger > > > From: "Gert Driesen" <[EMAIL PROTECTED]> > > To: "'kevin baribeau'" <[EMAIL PROTECTED]>, > > <[EMAIL PROTECTED]> > > Subject: RE: [NAntC-Dev] IIS Application roots > > Date: Wed, 24 Nov 2004 12:12:50 +0100 > > > > > > > -----Original Message----- > > > From: [EMAIL PROTECTED] > > > [mailto:[EMAIL PROTECTED] On > > > Behalf Of kevin baribeau > > > Sent: dinsdag 23 november 2004 20:26 > > > To: [EMAIL PROTECTED] > > > Subject: [NAntC-Dev] IIS Application roots > > > > > > Hi all. > > > > > > I've made a small change to the mkiisdir task to support creating > > > application roots on virtual directories. Here is a patch (created > > > with cvs diff -c) and a summary of the changes. > > > > > > > > > 1. Add a boolean attribute appcreate. If true, create an application > > > root on this directory, otherwise do nothing special. > > > > > > 2. Remove line setting "AppRoot" property. This is wrong according to > > > the documentation here (it was causing weird behaviour on iis 5): > > > > > > > > > http://msdn.microsoft.com/library/default.asp?url=/library/en- > > > us/iissdk/iis/ref_mb_approot.asp > > > > > > The appropriate quote is: "Important Because this property is > > > internally configured by IIS, you should consider it to be read-only. > > > Do not configure this property." > > > > > > 3. Add an if statement creating application root if the "AppCreate" > > > attribute is set to True. > > > > > > > > > I would appreciate it greatly if this change would be accepted into > > > the main development branch (nightly builds, cvs etc.). Also any > > > feedback and suggested changes / improvements are welcome. > > > > Kevin, can you add docs for the new "appcreate" ? > > > > Can someone else review this patch ? > > > > Gert > > > > --- > Outgoing mail is certified Virus Free. > Checked by AVG anti-virus system (http://www.grisoft.com). > Version: 6.0.733 / Virus Database: 487 - Release Date: 2004-08-02 > --- > Outgoing mail is certified Virus Free. > Checked by AVG anti-virus system (http://www.grisoft.com). > Version: 6.0.733 / Virus Database: 487 - Release Date: 2004-08-02 > > ------------------------------------------------------- > SF email is sponsored by - The IT Product Guide > Read honest & candid reviews on hundreds of IT Products from real users. > Discover which products truly live up to the hype. Start reading now. > http://productguide.itmanagersjournal.com/ > _______________________________________________ > NAntContrib-Developer mailing list > [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/nantcontrib-developer > ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://productguide.itmanagersjournal.com/ _______________________________________________ NAntContrib-Developer mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nantcontrib-developer
