Hey Matthew,
No problem.
Just send the patch to the NAntContrib developer mailing list
(nantcontrib-developer@lists.sourceforge.net).
Gert
_____
From: Matthew Thomas Krzan [mailto:[EMAIL PROTECTED]
Sent: donderdag 3 januari 2008 20:09
To: 'Gert Driesen'
Subject: RE: [NAntC-Dev] NAntContrib Developer Request
Gert,
Thanks for taking the time to give me an overview of the
contribution process.
Your alternative implementation is really good. I'm going to implement it
that way, post a patch, and hopefully get some more feedback on it. I'm
always game for constructive feedback.
In addition to the diff and patch, I was hoping to add some unit tests for
the original task (and my changes).
I didn't see any direct way to reference the original feature request I put
in, looking at the submit new patch in source forge, so I guess I just need
to put that in the details, correct?
This could also benefit honkster, who added patch "[1648001] VB6
Task fails to rebuild projects with designers", in that someone could do a
rebuild incase the ProjectNeedsCompiling method was unable to detect
changes, and they didn't have access/expertise to modify the source.
Thanks again!
Matthew Krzan,
(NT4 & 2k) MCP, MCSE
(NT4) MCP+I, MCSE+I
MCDBA (7.0, 2000), MCTS: SQL 2005
ACISS Systems, Inc.
From: Gert Driesen [mailto:[EMAIL PROTECTED]
Sent: Thursday, January 03, 2008 12:13 PM
To: 'Matthew Thomas Krzan'
Subject: RE: [NAntC-Dev] NAntContrib Developer Request
Hey Matthew,
I certainly welcome new contributors. The normal procedure for NAntContrib
(and most, if not all, open-source projects) is to have new contributors
first post (a few) patches to the developer list.
Normally patches are created as a unified diff (cvs diff -u), but it that's
a problem for you the full source file is ok too (for the first few
patches).
To implement the feature you requested, I would not add a force option but
instead would go for something like a "buildmode" option (although there
surely are better names for this), which takes the following values (as
defined by an enum):
Build (which would be default)
Rebuild (would match your "force" option)
Clean: (removes the expected output file(s))
What do you think?
Now, I'm sure there will be some (or perhaps even a lot of) remarks from me
(other other developers) on your first patches, but you should not take this
as negative critics.
I for one appreciate constructive feedback any time, and a good discussion
can only lead to better results.
Gert
_____
From: Matthew Thomas Krzan [mailto:[EMAIL PROTECTED]
Sent: donderdag 3 januari 2008 17:51
To: 'Gert Driesen'
Subject: RE: [NAntC-Dev] NAntContrib Developer Request
Gert,
Thanks for the email, sorry about the broadcast. I added a
simple feature request "[1845763] vb6 task force build option" for the vb6
task. I have already implemented it local and would like to contribute to
the project. I have CVS working with the annon user, so I think I could
publish it easily (once made a dev), however this is my first time actually
attempting to contribute to SF so any additional guidance you could provide
would be appreciated. Thanks!
Matthew Krzan,
(NT4 & 2k) MCP, MCSE
(NT4) MCP+I, MCSE+I
MCDBA (7.0, 2000), MCTS: SQL 2005
ACISS Systems, Inc.
From: Gert Driesen [mailto:[EMAIL PROTECTED]
Sent: Wednesday, January 02, 2008 12:45 PM
To: [EMAIL PROTECTED]; nantcontrib-developer@lists.sourceforge.net
Subject: RE: [NAntC-Dev] NAntContrib Developer Request
Hey Matthew,
You've been contacting the right people, well I'm kind of the only active
admin.
I probably missed your emails, or perhaps they were blocked by my spam
filter.
What area would you like to contribute to ?
Gert
_____
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of
Matthew Krzan
Sent: woensdag 2 januari 2008 17:56
To: nantcontrib-developer@lists.sourceforge.net
Subject: [NAntC-Dev] NAntContrib Developer Request
Hello All,
I have made a couple attempts to the admins to contribute to the project.
It's been about a month and I'm not sure if they are away for the holidays,
my request has been eaten by a spam filter or I'm just not asking the right
people (drieseng, ianm74 & skot). Any ideas? Thanks!
Matthew Krzan,
(NT4 & 2k) MCP, MCSE
(NT4) MCP+I, MCSE+I
MCDBA (7.0, 2000), MCTS: SQL 2005
ACISS Systems, Inc.
_____
i'm is proud to present Cause Effect, a series about real people making a
difference. Learn more
<http://im.live.com/Messenger/IM/MTV/?source=text_Cause_Effect>
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
NAntContrib-Developer mailing list
NAntContrib-Developer@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nantcontrib-developer
