* final missing in NativeFloat32Array and friends. * I want a unit test that checks that long is the correct representation for uint32 array elements. uint16 should be fine as it's chars I guess. * There is whitespace missing between functions in NativeUint8Array. * Can you check that all unsigned typed arrays work for boundary conditions.
Otherwise, looking very good. Nicely spotted. /M On 13 Oct 2014, at 20:34, Attila Szegedi <[email protected]> wrote: > Please review JDK-8060242 at > <http://cr.openjdk.java.net/~attila/8060242/webrev.00> for > <https://bugs.openjdk.java.net/browse/JDK-8060242> > > The fix is mostly in the TypeEvaluator.java, the rest is just plumbing > (ArrayBufferView has to be public so I can us it with instanceof; array data > subclasses for buffer views need to support optimistic operations; > Int/Long/Number/ObjectArrayData now inherit they getOptimisticType() from > ContinuousArrayData; finally there was a genuine data type bug where > NativeUint32Array reported its array element type to be int instead of long). > > Thanks, > Attila.
