Hi Sergey,
+1
Nice work! Good coverage!
Nitpick: class field in JSON may be removed - i.e., filtered out. All
those IfTreeImpl, LiteralTreeImpl etc. classes are package-private and
final -- not part of API. So, tests may avoid using those name for
better stability.
-Sundar
On Wednesday 18 March 2015 12:56 PM, Marcus Lagergren wrote:
+1
On 17 Mar 2015, at 13:11, Sergey Lugovoy <[email protected]> wrote:
Hi all,
Please review http://cr.openjdk.java.net/~slugovoy/8068306/webrev.01/
<http://cr.openjdk.java.net/~slugovoy/8068306/webrev.01/> for JEP 236: Parser
API for Nashorn
JEP : https://bugs.openjdk.java.net/browse/JDK-8058809
<https://bugs.openjdk.java.net/browse/JDK-8058809>
Test tasks :
Tests for Diagnostic listener for Nashorn Parser API -
https://bugs.openjdk.java.net/browse/JDK-8068304
<https://bugs.openjdk.java.net/browse/JDK-8068304>
Tests for AST presentation Nashorn Parser API -
https://bugs.openjdk.java.net/browse/JDK-8068306
<https://bugs.openjdk.java.net/browse/JDK-8068306>
Create tests for Nashorn Parser API for create Tree from some different source and
parameters - https://bugs.openjdk.java.net/browse/JDK-8068303
<https://bugs.openjdk.java.net/browse/JDK-8068303>
--
Thanks,
Sergey
