Thanks for the review. You are right, I followed your suggestion and made ScriptFunctionData#getBest abstract.

New webrev: http://cr.openjdk.java.net/~hannesw/8131340/webrev.01/

Thanks,
Hannes

Am 2015-07-17 um 13:28 schrieb Michael Haupt:
Hi Hannes,

Am 17.07.2015 um 12:27 schrieb Hannes Wallnoefer <[email protected]>:
Please review JDK-8131340: Varargs function is recompiled each time it is linked

http://cr.openjdk.java.net/~hannesw/8131340/

lower-case thumbs up, with one remark: getBest is now defined in SFD and 
overridden in RecompSFD, and the super call is gone, so the implementation of 
getBest in SFD is now only responsible for FinalSFD only - how about making it 
abstract in SFD and moving the implementation to FinalSFD?

Best,

Michael


Reply via email to