This is awesome. I want to run some tests, but it looks very good. Nice numbers too.
+0.5 (I’ll come back with the other +0.5 tomorrow when I’ve fully gone over all the code). Nicely done, Attila /M > On 26 Aug 2015, at 14:18, Attila Szegedi <attila.szeg...@oracle.com> wrote: > > Please review JDK-8133300 "Ensure symbol table immutability in Nashorn AST" > at <http://cr.openjdk.java.net/~attila/8133300/webrev.jdk9> for > <https://bugs.openjdk.java.net/browse/JDK-8133300> > > Implementation notes for reviewers are here: > <https://bugs.openjdk.java.net/browse/JDK-8133300?focusedCommentId=13837384&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13837384 > > <https://bugs.openjdk.java.net/browse/JDK-8133300?focusedCommentId=13837384&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13837384>> > > Thanks, > Attila.
