+1 Looks good to me too. Great that you cleaned up that “owner” generic. I can’t remember what else we had as owners in the beginning for CodeInstallers than ScriptEnvironments.
Nitpicks: not sure if we had a convention that static final fields are named UPPER_CASE_LIKE_THIS. We have e.g. the LongAdder called “emittedUnitCount” in CompileUnit etc. /M > On 10 Sep 2015, at 11:19, Hannes Wallnoefer <hannes.wallnoe...@oracle.com> > wrote: > > Looks good to me. > > Hannes > > Am 2015-09-09 um 15:35 schrieb Attila Szegedi: >> Please review JDK-8135251 "Use Unsafe.defineAnonymousClass for loading >> Nashorn script code" at >> <http://cr.openjdk.java.net/~attila/8135251/webrev.jdk9> for >> <https://bugs.openjdk.java.net/browse/JDK-8135251> >> >> Implementation notes are in >> <https://bugs.openjdk.java.net/browse/JDK-8135251?focusedCommentId=13841379&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13841379 >> >> <https://bugs.openjdk.java.net/browse/JDK-8135251?focusedCommentId=13841379&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13841379>> >> >> Thanks, >> Attila. >