Few minor remarks: * AssignSymbols.isSplitLiteral uses !(splitRanges == null || splitRanges.isEmpty()) while everywhere else in the code the check is (ranges != null). * loadSplitLiteral: seems like there's a stray comment: // method.load(literalType, literalSlot); * Terminology: Splittable is described as a "marker interface” yet it has a method.
Other than these small things, +1. Attila. > On Sep 18, 2015, at 12:03 PM, Hannes Wallnoefer > <hannes.wallnoe...@oracle.com> wrote: > > Please review JDK-8135190: Method code too large in Babel browser.js script: > > http://cr.openjdk.java.net/~hannesw/8135190/ > > This makes object literals splittable. I tried to share as much code as > possible with array literal splitting so I had to introduce a couple of new > interfaces. > > Hannes
