Thanks, fixed those.

> On Oct 20, 2015, at 4:22 PM, Hannes Wallnoefer <hannes.wallnoe...@oracle.com> 
> wrote:
> 
> +1, some very nice documentation there. Two minor issues I found:
> 
> DefaultInternalObjectFilter.java class javadoc: "on those parameters and 
> return values types that are declared to have type {@link Object}": the first 
> "types" should be removed.
> 
> DynamicLinker.java class javadoc: "A dynamic linker a main objects when using 
> Dynalink...": not a proper sentence.
> 
> Hannes
> 
> 
> Am 2015-10-19 um 16:34 schrieb Attila Szegedi:
>> Please review JDK-8139888 "Improve Dynalink JavaDoc some more" at 
>> <http://cr.openjdk.java.net/~attila/8139888/webrev.jdk9> for 
>> <https://bugs.openjdk.java.net/browse/JDK-8139888>
>> 
>> This is the last anticipated JavaDoc focused changeset.
>> 
>> In addition to JavaDoc improvements, there are few minor changes:
>> - DynamicLinkerFactory rejects nulls in lists of linkers being passed
>> - LinkRequest.replaceArguments was made variable arity (taking Object… as 
>> its last arg instead of Object[]), making it consistent with 
>> SipleLinkRequest constructor
>> - SimpleLinkRequest rejects nulls in constructor parameters now, and clones 
>> incoming arguments lists
>> - Lookup and NameCodec classes were made final
>>  Thanks,
>>   Attila.
> 

Reply via email to