Hi,

[ Replying based on url from JIRA update. I'm yet to get email from nashorn-dev list]

Nashorn team runs test via "ant clean test". Only a subset of tests are enabled for jtreg by appropriate jtreg tags. In this case, these tests were enabled without running jtreg.

I see that you've fixed the tests to run in jtreg mode - not sure if 'ant clean test' is okay or not ("test.src" system property and default of "." to fetch resources - not sure if ant test is fine). If ant run is fine, we can go ahead with your fix.

If not (or if you've not run ant), I propose to disable jtreg mode for these tests:

    http://cr.openjdk.java.net/~sundar/8142501/webrev.00/

to unblock others and get back to making the test work in both jtreg and ant mode by a later fix.

PS. After disabling for jtreg mode, I tested that jtreg mode and ant mode are fine.

Thanks,
-Sundar

Reply via email to