Hi Hannes, lower-case thumbs up.
Best, Michael > Am 12.11.2015 um 16:36 schrieb Hannes Wallnoefer > <hannes.wallnoe...@oracle.com>: > > Please review JDK-8142864: Raw types warning in WeakValueCache: > > http://cr.openjdk.java.net/~hannesw/8142864/webrev/ > > This removes a warning in WeakValueCache.java, and I also reduced methods by > combining code as suggested by Attila. > > Furthermore I renamed method in isWrappedPrimitiveAndObject in > ScriptRuntime.java to isPrimitiveAndObject because the primitives are not > wrapped (at least not in the JavaScript meaning of the word). > > Thanks, > Hannes -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment
