Thanks; I tried to find other patterns for similar behavior, but I’m not sure what you’re referring to. On the other hand, this feels right to me as it is; I often prefer reducing the indentation level of code. Also, the next patch actually replaces “return null” with linking of the no such member handler.
> On Jan 11, 2016, at 11:18 AM, Michael Haupt <michael.ha...@oracle.com > <mailto:michael.ha...@oracle.com>> wrote: > > Hi Attila, > > lower-case thumbs-up, with one remark: > AbstractJavaLinker.getNextComponent(ComponentLinkRequest) could be rewritten > like so (matching patterns applied elsewhere in the patch): > > GuardedInvocationComponent getNextComponent(final ComponentLinkRequest req) > throws Exception { > if (!req.operations.isEmpty()) { > final GuardedInvocationComponent gic = > getGuardedInvocationComponent(req); > return gic != null ? gic : getNextComponent(req.popOperations()); > } > return null; > } > > Best, > > Michael > >> Am 23.12.2015 um 21:30 schrieb Attila Szegedi <szege...@gmail.com >> <mailto:szege...@gmail.com>>: >> >> Please review JDK-8144917 "Prepare AbstractJavaLinker/BeanLinker codebase >> for missing member implementation" at >> <http://cr.openjdk.java.net/~attila/8144917/webrev.jdk9 >> <http://cr.openjdk.java.net/~attila/8144917/webrev.jdk9>> for >> <https://bugs.openjdk.java.net/browse/JDK-8144917 >> <https://bugs.openjdk.java.net/browse/JDK-8144917>> >> >> This change has no functional effects, it's a refactoring for easier >> introduction of the no-such-member implementation (JDK-8144919), a review >> for which will immediately follow. I only plan to commit the two together >> after they have been both reviewed. >> >> Thanks, >> Attila. > > -- > > <http://www.oracle.com/> > Dr. Michael Haupt | Principal Member of Technical Staff > Phone: +49 331 200 7277 | Fax: +49 331 200 7561 > Oracle Java Platform Group | LangTools Team | Nashorn > Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany > <http://www.oracle.com/commitment> Oracle is committed to developing > practices and products that help protect the environment >
