Hi Hannes, lower-case thumbs up.
Best, Michael > Am 20.01.2016 um 14:10 schrieb Hannes Wallnoefer > <hannes.wallnoe...@oracle.com>: > > Please review backport to 8u-dev of JDK-8144020: Remove long as an internal > numeric type: > > http://cr.openjdk.java.net/~hannesw/8144020/webrev-8u/ > > There was some manual merging necessary in the following files: > > src/jdk/nashorn/internal/codegen/LocalVariableTypesCalculator.java > src/jdk/nashorn/internal/codegen/SpillObjectCreator.java > src/jdk/nashorn/internal/ir/debug/NashornTextifier.java > src/jdk/nashorn/internal/objects/NativeArray.java > src/jdk/nashorn/internal/parser/Lexer.java > src/jdk/nashorn/internal/runtime/JSType.java > src/jdk/nashorn/internal/runtime/OptimisticReturnFilters.java > src/jdk/nashorn/internal/runtime/ScriptObject.java > src/jdk/nashorn/internal/runtime/arrays/LongArrayData.java > > I chose to omit the changes to ir/debug/NashornTextifier.java and > runtime/linker/NashornCallSiteDescriptor.java (cleaning up bytecode printing) > as it is not an essential part of this patch and would have required more > changes in NashornTextifier.java. > > Thanks > Hannes -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment