Few remarks (even though I see this was committed already): - ScriptingFunctions.exec declares IOException and InterruptedException, but these are never thrown by any code in the method. If the intent is for these to be propagated, it should be investigated if they’re inadvertently swallowed somewhere.
- CommandExecutor.java:592 creates an unused ByteArrayInputStream (probably a leftover from editing as the same expression is repeated as one of the parameters in the line below it). Finally, CommandExecutor.createTokenizer and .stripQuotes could be static methods, and there’s a whole bunch of parameters and local variables that should be declared final. I’m just observing this for posterity as this is no big deal as we can have anybody with a configured IDE just pass it through it and it'll appropriately add the “final” keywords where needed. Attila. > On Feb 9, 2016, at 9:18 PM, Jim Laskey (Oracle) <james.las...@oracle.com> > wrote: > > https://bugs.openjdk.java.net/browse/JDK-8141209 > http://cr.openjdk.java.net/~jlaskey/8141209/webrev/index.html > > Rough documentation can be found at > https://community.oracle.com/community/java/javascript-nashorn/blog/2016/02/08/proposal-for-exec-20 >
