No diffs in ScriptingFunctions.java. Whitespace? +1
-Sundar On 3/9/2016 5:59 PM, Michael Haupt wrote: > All, > > the updated webrev is at > http://cr.openjdk.java.net/~mhaupt/8151291/webrev.01/ - please review. > > The issue is a bit deeper. The way the current working directory is > initialised and subsequently handled was the root cause of the observed > problems. Cygwin being a unixy environment somewhat forcefully inflicted on > Windows, and Java assuming that the underlying platform is, after all, > Windows and consequently using Windows path conventions did not coexist too > well. > > The gist of the fix is to unconditionally initialise $ENV.PWD to the Java > property user.dir, which is always in a form that the underlying platform can > understand. > > Thanks, > > Michael > >> Am 08.03.2016 um 15:50 schrieb Michael Haupt <michael.ha...@oracle.com>: >> >> All, >> >> I revoke the RFR for the time being; there is another issue with invoking >> $EXEC from within a Cygwin directory that does not have a /cygdrive prefix >> (e.g., /home/...). This will require some deeper investigation. >> >> Once a solution is in place, I will post another RFR in this thread. >> >> Best, >> >> Michael >> >>> Am 08.03.2016 um 11:35 schrieb Michael Haupt <michael.ha...@oracle.com>: >>> >>> Hi Srini, >>> >>>> Am 07.03.2016 um 19:36 schrieb Srinivas Dama <srinivas.d...@oracle.com>: >>>> Few limitations with absolute paths. >>>> On cmd.exe: >>>> jjs -scripting >>>> $EXEC("D:\work\nashorn-dev\dev\build\windows-x86_64-normal-server-release\images\jdk\bin\java.exe") >>>> >>> I assume you meant to say this fails - using double backslashes helps. :-) >>> >>>> Good thing is on cygwin if we give mixed path like: >>>> $EXEC("D:/work/nashorn-dev/dev/build/windows-x86_64-normal-server-release/images/jdk/bin/java.exe"),it >>>> works. >>>> But >>>> $EXEC("/cygdrive/d/work/nashorn-dev/dev/build/windows-x86_64-normal-server-release/images/jdk/bin/java.exe") >>>> fails. >>> Yes, that's not right. I've addressed that. I need another round of reviews >>> please: http://cr.openjdk.java.net/~mhaupt/8151291/webrev.00 (note that I >>> accidentally deleted the previous webrev). >>> >>> Thanks, >>> >>> Michael
