+1 -Sundar
On 4/26/2016 3:28 PM, Hannes Wallnoefer wrote: > Thanks for the reviews. I uploaded a new webrev: > > http://cr.openjdk.java.net/~hannesw/8134503/webrev.01/ > > I left the copyright year as 2015, 2016 for those files I got with > that date from Andreas, I think that's the correct thing to do. > > The change of endPosition for object literal property nodes is in fact > more precise now. It used to be the end position of the property name, > whereas now it is the end position of the whole property (including > its value). > > Hannes > > Am 2016-04-25 um 14:19 schrieb Sundararajan Athijegannathan: >> * new sources copyright year to be 2016 >> >> * can the new IR node classes be final? ClassNode etc.? >> >> * .EXPECTED files have new endPosition now. are we being precise now? >> >> +1 >> >> -Sundar >> >> On 4/25/2016 5:19 PM, Hannes Wallnoefer wrote: >>> Please review JDK-8134503: support ES6 parsing in Nashorn >>> >>> http://cr.openjdk.java.net/~hannesw/8134503/webrev/ >>> >>> The original patch was contributed by Andreas Woess, I just did the >>> integration into Nashorn tip. >>> >>> Thanks, >>> Hannes >
