+1
> On May 13, 2016, at 12:52 PM, Hannes Wallnoefer
> <hannes.wallnoe...@oracle.com> wrote:
>
> Please review JDK-8156714: Parsing issue with automatic semicolon insertion:
>
> http://cr.openjdk.java.net/~hannesw/8156714/webrev/
>
> Comments are irrelevant for newline detection so we should ignore them when
> assigning to AbstractParser.last.
>
> Note that this causes three endPositions to change in
> test/script/nosecurity/parserapi.js.EXPECTED. This is caused by the parser
> API no longer including trailing comments to functions.
>
> For example consider the following code (taken from parserapi.js itself, this
> is the first changed endPosition):
>
> function Parser() {
> // create nashorn parser
> this._parser = Parser.create();
> }
>
> // Java types used
>
>
> Previously the endPosition of the Parser function would be the end of the
> trailing comment. With this change, the function's endPosition is before the
> trailing comment starts, which seems more correct.
>
> Hannes
