Hi Sundar, lower-case thumbs up, with remarks.
* "is this a overridable" -> "... an overridable" * My feeling: the name isOverridableObjectMethod would describe the method's intent more clearly. * How about comparing the method types to statically initialised MethodType instances obtained from the methods in question? Best, Michael > Am 25.05.2016 um 12:49 schrieb Sundararajan Athijegannathan > <sundararajan.athijegannat...@oracle.com>: > > Please review http://cr.openjdk.java.net/~sundar/8157819/webrev.00 for > https://bugs.openjdk.java.net/browse/JDK-8157819 > > Thanks, > > -Sundar > -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment
