Hi Andreas, you’re of course right about NamedOperation finality, that’s an oversight on my part. Also thanks for catching the documentation error. I’ll fix both.
Thanks, Attila. > On 26 Oct 2016, at 18:30, Andreas Woess <andreas.wo...@oracle.com> wrote: > > Not a review, but one remark: it does not make sense that NamedOperation > is a final class given the protected changeNameInternal method. > Also, in the javadoc of this class: "The contract for these operation is" > > Regards, > Andreas > > On 2016-10-26 12:48, Attila Szegedi wrote: >> Please review JDK-8168005 "Introduce namespaces for GET, SET Dynalink >> operations" at <http://cr.openjdk.java.net/~attila/8168005/webrev.jdk9> for >> <https://bugs.openjdk.java.net/browse/JDK-8168005> >> >> The JIRA issue has detailed rationale for the change. The diff is moderately >> large, but the Dynalink API changes are only a part of it, the rest is >> adjusting Nashorn, code examples, and tests to the changed API. >> >> Thanks, >> Attila. >> >
