+1

-Sundar

On 29/08/17, 9:24 AM, Priya Lakshmi Muthuswamy wrote:
Thanks Sundar for the comments.
Modified the test.
Revised patch: http://cr.openjdk.java.net/~pmuthuswamy/8184723/webrev.01/

Thanks,
Priya

On 8/29/2017 8:59 AM, Sundararajan Athijegannathan wrote:
Line 41 of the test:

new jdk.nashorn.api.scripting.NashornScriptEngineFactory

* could use an import statement and unqualified name and that line is very long too.

+1 otherwise.

-Sundar

On 29/08/17, 8:48 AM, Priya Lakshmi Muthuswamy wrote:
Hi,

Please review JDK-8184723: jdk.nashorn.internal.runtime.linker.JSObjectLinker.callToApply erroneously asserts given arguments

JBS: https://bugs.openjdk.java.net/browse/JDK-8184723
webrev: http://cr.openjdk.java.net/~pmuthuswamy/8184723/webrev.00/

Thanks,
Priya

Reply via email to