Hi Attila, > Am 26.11.2017 um 19:51 schrieb Attila Szegedi <szege...@gmail.com>: > > I’m able to spend some free time again on OpenJDK development, and one thing > I have on my plate is adding a REMOVE operation to Dynalink. >
great! > This CR however, is not yet it: that will require a CCC sponsorship etc. as > I’ll be adding a new enum value to StandardOperations, and I will follow up > separately once I’m done with it. I was going to point you to the new CSR issue type, but I see you found your way already. > What this is a refactoring of BeanLinker code to eliminate most of the code > duplication between getElementGetter and getElementSetter methods. This would > be justified on its own, but once I need to add the getElementRemover method, > it will really pay off as then we won’t have triplication of similar code. > > With that in mind, please review JDK-8191878 "Reduce code duplication in > BeanLinker" at <http://cr.openjdk.java.net/~attila/8191878/webrev.jdk10> for > <https://bugs.openjdk.java.net/browse/JDK-8191878> > +1 Hannes > Thanks, > Attila. >
