+1 Hannes
> Am 08.12.2017 um 10:26 schrieb Priya Lakshmi Muthuswamy > <priya.lakshmi.muthusw...@oracle.com>: > > Thanks Sundar. I have modified the test. > > updated webrev : http://cr.openjdk.java.net/~pmuthuswamy/8193137/webrev.01/ > > Thanks, > Priya > On 12/8/2017 2:40 PM, Sundararajan Athijegannathan wrote: >> Looks good. The test uses $EXEC("rm..."). Better to avoid that [what about >> Windows?] - use Java API to delete file instead./ >> / >> -Sundar >> >> On 08/12/17, 2:09 PM, Priya Lakshmi Muthuswamy wrote: >>> Hi, >>> >>> Please review JDK-8193137 : Nashorn crashes when given an empty script file >>> >>> JBS : https://bugs.openjdk.java.net/browse/JDK-8193137 >>> webrev : http://cr.openjdk.java.net/~pmuthuswamy/8193137/webrev.00/ >>> >>> Thanks, >>> Priya >
