Can I get another review?
> On Dec 25, 2017, at 10:59 AM, Attila Szegedi <szege...@gmail.com> wrote:
>
> Yeah, JDK 11. There’s no visible changes, so it doesn’t really make sense
> pushing it into JDK 10.
>
>> On Dec 21, 2017, at 9:37 PM, Hannes Wallnöfer <hannes.wallnoe...@oracle.com>
>> wrote:
>>
>> Interesting. I bet the answer is in the commits from before we went open
>> source.
>>
>> +1
>>
>> I assume this is for JDK 11?
>>
>> Hannes
>>
>>> Am 21.12.2017 um 19:20 schrieb Attila Szegedi <szege...@gmail.com>:
>>>
>>> Please review JDK-8193295 "Remove no longer used COMMALEFT" at
>>> <http://cr.openjdk.java.net/~attila/8193295/webrev.jdk> for
>>> <https://bugs.openjdk.java.net/browse/JDK-8193295>
>>>
>>> I love deleting code :-)
>>>
>>> COMMALEFT was an odd duck, as there’s not really anything in the ES
>>> specification that’d require it, and we really don’t even use it for
>>> anything. I had a memory that we used to use it for some behavior around
>>> object literals, but I can’t find any traces of that… I run:
>>>
>>> hg log --template "{ifcontains('COMMALEFT', diff(), '{node} {desc}\n',
>>> '')}”
>>>
>>> and trawled through the diffs for all changesets it brought up, but I
>>> haven’t found a single use of COMMALEFT ever.
>>>
>>> Thanks,
>>> Attila.
>>
>
