On Thu, 2005-12-01 at 15:22 +0100, Christian Neumair wrote:
> Christian Kellner asked me to improve and submit a patch to this list
> that makes Nautilus use GNOME_VFS_FILE_INFO_FIELDS_ACCESS for
> determining file permissions.
> I've also attached a patch that makes gnome_vfs_file_info_matches check
> for valid_fields being identical, since this can make client
> applications assume that two file infos match where they don't, and
> Nautilus uses it.
>
> OK to commit?
@@ -2474,7 +2476,8 @@ mime_list_load (NautilusDirectory *direc
gnome_vfs_async_load_directory
(&directory->details->mime_list_in_progress,
uri,
- GNOME_VFS_FILE_INFO_GET_MIME_TYPE,
+ GNOME_VFS_FILE_INFO_GET_MIME_TYPE
+ | GNOME_VFS_FILE_INFO_GET_ACCESS_RIGHTS,
DIRECTORY_LOAD_ITEMS_PER_CALLBACK,
GNOME_VFS_PRIORITY_DEFAULT,
mime_list_callback,
No need to pass this in mime_list_load.
- /* Other users' access is governed by the other bits. */
- return (file->details->info->permissions & other_permission) == 0;
+ return (file->details->info->permissions & permissions) == 0;
}
I think "and" semantics is better, so this should be:
(file->details->info->permissions & permissions) != permissions
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Alexander Larsson Red Hat, Inc
[EMAIL PROTECTED] [EMAIL PROTECTED]
He's a suave hunchbacked senator searching for his wife's true killer. She's a
manipulative extravagent snake charmer with a birthmark shaped like Liberty's
torch. They fight crime!
--
nautilus-list mailing list
[email protected]
http://mail.gnome.org/mailman/listinfo/nautilus-list