On Fri, May 9, 2008 at 7:11 PM, Vlad Seryakov
<[EMAIL PROTECTED]> wrote:
> Update of /cvsroot/naviserver/naviserver/nsd
> In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv5680/nsd
>
> Modified Files:
> adprequest.c
> Log Message:
> * nsd/adprequest.c: Fixed situation when adp registered absolute path
> outside of the page root.
>
> Output error message when registered adp callback could resolve file
>
> if (file == NULL) {
> + Ns_Log(Error, "adp file not found for %s %s, file=%s, flags=0x%x",
> + conn->request->method, conn->request->url, adp->file,
> adp->flags);
> status = Ns_ConnReturnInternalError(conn);
> goto done;
Maybe this should just return a 404?
I guess the idea behind the internal error is that if you register an
ADP with a fully qualified path and the file does not exist then it is
a config error. But it is kind of weird to stat the file at
registration time -- we don't do that anywhere else -- so the error is
delayed to runtime.
If someone moves a file without bouncing the server the error-log may
fill up before anyone notices.
A 404 is probably a big enough clue as to what's gone wrong.
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
naviserver-devel mailing list
naviserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/naviserver-devel
