On 17.10.12 13:21, Gustaf Neumann wrote: > With this committed, there are still the typcast changes to > address, ....
dear all, i have done one more cleanup round and removed all warnings when naviserver is compiled with "clang -Wall -pedantic". These changes were mostly mixtures between function pointers and data pointers (it warns about passing a function pointer via "void*", i have used the rather generic type Ns_Callback instead) and arithmetics on "void*" (which is a gnu extension). I have as well removed a bunch of unneeded assignments. What are the opinions about changes from maurizios diff like - argPtr = ns_malloc(sizeof(Arg)); + argPtr = (Arg *) ns_malloc(sizeof(Arg)); or NsTclServerObjCmd(ClientData arg, Tcl_Interp *interp, int objc, Tcl_Obj **objv) { int opt; - NsInterp *itPtr = arg; + NsInterp *itPtr = (NsInterp *) arg; do we really need these? changes in the first category could be done e.g. with a macro... -gustaf neumann ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_sfd2d_oct _______________________________________________ naviserver-devel mailing list naviserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/naviserver-devel