I've just committed the patch since nobody was against it and Puga confirmed it works. If you agree, I'll close the bugs too, but not before doing quick tests just in case of missing something ;)
2011/5/24 Francisco Puga <[email protected]>: > Hi, > > The patch solves all the bugs recollected in this wiki page [1]. I > think you can commit it and close the bugs. > > I tested it with postgis too. > > The only that does not work is if you change a value in navtable. The > change is not reflected in "real time" in the gvSIG table, but when > the edition is close it appears. > > > [1] > http://forge.osor.eu/plugins/wiki/index.php?RFCKeepRecordsetUpdated&id=122&type=g > > El día 20 de mayo de 2011 14:09, Javier Estévez <[email protected]> escribió: >> Hi, >> >> I've made more changes to solve all problems around changes on >> recordset made outside NavTable. I send the patch attached to this >> mail (it solves several known bugs, so I prefer to send it here >> instead of attaching on every bug). Can anybody test it and tell me >> your opinion? >> >> Best, >> Javi >> >> >> El día 18 de mayo de 2011 18:52, Javier Estévez <[email protected]> >> escribió: >>> After a light testing, it seems that my change doesn't fix the add new >>> features bug. As this is a first step, I'll work on develop solutions >>> other bugs [1] based on this one :) >>> >>> [1] >>> http://forge.osor.eu/plugins/wiki/index.php?RFCKeepRecordsetUpdated&id=122&type=g >>> >>> El día 18 de mayo de 2011 18:41, Javier Estévez <[email protected]> >>> escribió: >>>> Hi, >>>> >>>> since it seems that Fran Peñarrubia has taken care of the bug [1] in >>>> gvSIG's edition listeners (gvSIG rev #35162), I've just committed my >>>> work. >>>> >>>> I've also updated NavTable's bug [2], but I haven't closed it. What is >>>> the bug closing policy? >>>> >>>> I haven't tested it, but this commit should also fix the bug about >>>> adding new features [3], and it shouldn't fix any bug on changing >>>> schema [4,5]. >>>> >>>> Best, >>>> Javi >>>> >>>> [1] >>>> http://forge.osor.eu/tracker/?func=detail&group_id=89&aid=15287&atid=732 >>>> [2] >>>> http://forge.osor.eu/tracker/index.php?func=detail&aid=15007&group_id=122&atid=462 >>>> [3] >>>> http://forge.osor.eu/tracker/index.php?func=detail&aid=15213&group_id=122&atid=462 >>>> [4] >>>> http://forge.osor.eu/tracker/index.php?func=detail&aid=15163&group_id=122&atid=462 >>>> [5] >>>> http://forge.osor.eu/tracker/index.php?func=detail&aid=14504&group_id=122&atid=462 >>>> >>>> 2011/4/29 Andrés Maneiro <[email protected]>: >>>>> Javi, I've tested the patch with navtable and navtableforms. Here the >>>>> summary: >>>>> >>>>> On changing values: >>>>> >>>>> - edit/insert/delete operations: recordset on navtable/navtableforms is >>>>> updated. >>>>> >>>>> On changing the geom: >>>>> >>>>> - delete a geom: recordset on navtable/navtableforms is updated >>>>> - update a geom: area and length are updated on navtable >>>>> - insert a geom: recordset on navtable/navtableforms is updated[1] >>>>> >>>>> It's ok for me to integrate this patch. I'd do as soon as posible as it >>>>> is a great step forward! It closes the two bugs related to change >>>>> recordset (values or geometry). >>>>> >>>>> Javi, great and nice work! >>>>> >>>>> best, >>>>> amaneiro >>>>> >>>>> [1] in this case, the recordset isn't update until NT refresh the >>>>> recordset, which happens for example if you go to the next record. >>>>> That's the most we can do until gvsig integrates the patch for listening >>>>> the end of a geometry. >>>>> >>>>> >>>>> On 26/04/11 17:37, Javier Estévez wrote: >>>>>> Hi, >>>>>> >>>>>> I've been taking care of the edition listening issue on NavTable [1] and >>>>>> I've found that there's a listener to listen to changes on the data >>>>>> source. It is IEditionListener. Its method afterRowEditEvent is called >>>>>> whenever a value is changed in the recordset. >>>>>> >>>>>> I've written a patch that solves this problem, but it doesn't work >>>>>> AlphanumericNavTable. There's a possible bug in gvSIG I've reported >>>>>> yesterday on their lists [2]. I send it attached. >>>>>> >>>>>> It works for me, but I'd like that some test it too. I've only tested it >>>>>> with NavTable, so it would be nice to test it with a NavTableForm too :) >>>>>> >>>>>> Anyway, maybe it's safer to wait if someone answers to my questions >>>>>> about the listener in gvSIG. >>>>>> >>>>>> Best, >>>>>> Javi >>>>>> >>>>>> >>>>>> [1] >>>>>> http://forge.osor.eu/plugins/wiki/index.php?RFCKeepRecordsetUpdated&id=122&type=g >>>>>> >>>>>> [2] >>>>>> http://osgeo-org.1803224.n2.nabble.com/modify-row-listener-td6303209.html >>>>>> >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> Navtable-devel mailing list >>>>>> [email protected] >>>>>> https://lists.forge.osor.eu/listinfo/navtable-devel >>>>> _______________________________________________ >>>>> Navtable-devel mailing list >>>>> [email protected] >>>>> https://lists.forge.osor.eu/listinfo/navtable-devel >>>>> >>>> >>>> >>>> >>>> -- >>>> Javier Estévez Valiñas >>>> segmentation fault: http://valdaris.com/ >>>> 100 pixels: http://pixel.valdaris.com/ >>>> ghandalf: http://www.ghandalf.org/ >>>> >>> >>> >>> >>> -- >>> Javier Estévez Valiñas >>> segmentation fault: http://valdaris.com/ >>> 100 pixels: http://pixel.valdaris.com/ >>> ghandalf: http://www.ghandalf.org/ >>> >> >> >> >> -- >> Javier Estévez Valiñas >> segmentation fault: http://valdaris.com/ >> 100 pixels: http://pixel.valdaris.com/ >> ghandalf: http://www.ghandalf.org/ >> >> _______________________________________________ >> Navtable-devel mailing list >> [email protected] >> https://lists.forge.osor.eu/listinfo/navtable-devel >> >> > > > > -- > Francisco Puga > Grupo de Desarrollo > Cartolab - Laboratorio de Ingeniería Cartográfica. > http://www.cartolab.es > > ETS Ingeniería de Caminos, Canales y Puertos > Universidade da Coruña > Campus de Elviña - 15071 A Coruña (España) > (34)981167000 ext. 5493 > _______________________________________________ > Navtable-devel mailing list > [email protected] > https://lists.forge.osor.eu/listinfo/navtable-devel > -- Javier Estévez Valiñas segmentation fault: http://valdaris.com/ 100 pixels: http://pixel.valdaris.com/ ghandalf: http://www.ghandalf.org/ _______________________________________________ Navtable-devel mailing list [email protected] https://lists.forge.osor.eu/listinfo/navtable-devel
