On Wed, Sep 7, 2011 at 1:52 PM, Paolo Bonzini <[email protected]> wrote: > On 09/07/2011 06:30 PM, Paul Clements wrote: >> >> Could you name this as NBD_SET_FLAGS, as that's more consistent with >> what it's really doing? > > I named it differently intentionally, actually, because it should not use > the flags field from the network protocol as is. Also, "features" sounds > more like something that is optional, while unrecognized "flags" should > probably cause a failure.
Alright, I can buy that argument -- I don't feel that strongly about it... This looks good to me, then. -- Paul ------------------------------------------------------------------------------ Using storage to extend the benefits of virtualization and iSCSI Virtualization increases hardware utilization and delivers a new level of agility. Learn what those decisions are and how to modernize your storage and backup environments for virtualization. http://www.accelacomm.com/jaw/sfnl/114/51434361/ _______________________________________________ Nbd-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/nbd-general
