On Mon, Mar 11, 2013 at 05:02:00PM -0400, Paul Clements wrote: > On Sun, Mar 10, 2013 at 5:53 PM, Michal Belczyk <[email protected]> wrote: > > On Sun, Mar 03, 2013 at 03:53:02PM +0100, Michal Belczyk wrote: > >> Hi there, > >> > >> a few months ago I noticed that nbd-client (kmod code actually) randomly > >> shuts down the connection during heavy parallel xdd benchmarks in my > >> local setup. The following change to nbd.c fixed that for me: > >> > >> @@ -303,9 +303,13 @@ > >> struct request *req, *tmp; > >> int err; > >> > >> +wait: > >> err = wait_event_interruptible(nbd->active_wq, nbd->active_req != > >> xreq); > >> - if (unlikely(err)) > >> + if (unlikely(err)) { > >> + if (err == -ERESTARTSYS) > >> + goto wait; > >> goto out; > >> + } > >> > >> Please consider pushing it upstream. > >> Thanks! > > > > I was able to hit this bug with the stock nbd-server, it is NOT > > bnbd-specific. If this mailing list is the wrong place to submit NBD > > driver bugs, then please point me to the proper location, although I > > believe there are kernel people signed up here as well... > > Thanks, I'll reformat and send upstream...
Thank you! -- Michal Belczyk Sr. ------------------------------------------------------------------------------ Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the endpoint security space. For insight on selecting the right partner to tackle endpoint security challenges, access the full report. http://p.sf.net/sfu/symantec-dev2dev _______________________________________________ Nbd-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/nbd-general
