Michal,

thanks for this...a couple of preliminary questions...

On Mon, Jun 17, 2013 at 4:10 PM, Michal Belczyk <[email protected]>wrote:

> The main idea behind it is to be able to quickly detect broken replica
> and switch over to another when used with any sort of mirror type device
> built on top of any number of nbd devices.
>

I'm wondering if a simpler change would have the same result. Namely, could
you just apply the xmit_timeout, as currently implemented, to the recvmsg
path (ignoring the timeout, of course, when no requests are queued). Is
there a case that this would not handle that the proposed patch handles?
They seem to be equivalent.


Also move nbd->pid modifications behind nbd->tx_lock wherever possible
> to avoid races between the concurrent nbd-client invocations.
>

Is there a bug related to this that you've seen, or is this just a
precaution?

Thanks,
Paul
------------------------------------------------------------------------------
Get your SQL database under version control now!
Version control is standard for application code, but databases havent 
caught up. So what steps can you take to put your SQL databases under 
version control? Why should you start doing it? Read more to find out.
http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk
_______________________________________________
Nbd-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/nbd-general

Reply via email to