On 2015-02-15 22:56, Markus Pargmann wrote: > On Sat, Feb 14, 2015 at 11:30:24AM +0100, Wouter Verhelst wrote: >> On Thu, Feb 12, 2015 at 09:57:31PM +0100, Markus Pargmann wrote: >> > The header is not included anywhere. Remove it and include the >> private >> > nbd_device struct in nbd.c. >> >> It exists mostly for the benefit of userspace trying to speak the >> NBD >> protocol. I've stopped trying to depend on it (since nbd-server >> needs to >> run on !Linux, too), but there are other implementations that might >> want >> to use it. >> >> nbd.h is part of a public API. Let's not drop it. > > This is just about the kernel internal header include/linux/nbd.h. It > is > not about the uapi header. I don't want to remove the protocol > header. > > The header this patch is about defines only 'struct nbd_device' which > is > as far as I can tell only used by nbd.c.
Whoops; I hadn't noticed that had been split up. Yeah, no objection then. -- It is easy to love a country that is famous for chocolate and beer -- Barack Obama, speaking in Brussels, Belgium, 2014-03-26 ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=190641631&iu=/4140/ostg.clktrk _______________________________________________ Nbd-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/nbd-general
