nbd_thread_send() does kernel_dequeue_signal() at the end for no reason, it is fine to exit with the pending SIGKILL.
Not sure it really needs another kernel_dequeue_signal() inside the main loop, we know that signal_pending() means SIGKILL. But probably we want to clear TIF_SIGPENDING before sock_shutdown(). Signed-off-by: Oleg Nesterov <[email protected]> --- drivers/block/nbd.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index b85e7a0..e5d96e5 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -586,10 +586,6 @@ static int nbd_thread_send(void *data) nbd->task_send = NULL; spin_unlock_irqrestore(&nbd->tasks_lock, flags); - /* Clear maybe pending signals */ - if (signal_pending(current)) - kernel_dequeue_signal(NULL); - return 0; } -- 1.5.5.1 ------------------------------------------------------------------------------ _______________________________________________ Nbd-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/nbd-general
