On 13 Apr 2016, at 16:24, Eric Blake <ebl...@redhat.com> wrote: >>> >>> + * `NBD_INFO_MAXIMUM_BLOCK` (4) >>> + >>> + The *info length* MUST be 4, and represents the maximum block >>> + size. See the "Block sizes" section for further requirements on >>> + its value. >>> + >>> + - 32 bits, maximum block size >> >> I like these. > > Is it worth keeping the three separate (where the server can advertise > one, but not all three, and the others fall back to defaults), or is it > easier to just always require all three to be present (since we've > documented sane defaults, a server should always be able to supply > something)?
I think having them all in one option is easier. I guess we could permit '0' to mean 'the default' but TBH I'd prefer if you specified one of them you specify all of them, which would also avoid the need for the rather convoluted language I tried to suggest about the need to ensure that if you only specify some of them those ones need to be compatible with the default. -- Alex Bligh
signature.asc
Description: Message signed with OpenPGP using GPGMail
------------------------------------------------------------------------------ Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
_______________________________________________ Nbd-general mailing list Nbd-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nbd-general
