On Wed 2016-05-11 07:46:25, Eric Blake wrote: > On 05/11/2016 03:38 AM, Pranay Srivastava wrote: > > > > > The series contained some checkpatch changes so I had included you as well. > > > >> know why you are sending them to me), but I know I do not accept patches > >> without any changelog text at all in them, as that's just lazy. > > > > That should be per patch or can appear in a cover letter for the patches? > > Per patch. However, if it were me, I would not have split into quite so > many patches. The mantra is one patch per one fix, but I think it is > reasonable to state that "silence all checkpatch warnings" counts as one > fix, rather than 16 separate fixes. If you DO consolidate the > checkpatch changes into a single patch, then the commit message body > should call out a bulleted list of all the changes you are making, as > well as a justification why it is worth churning the entire file rather > than just making smaller checkpatch fixes in just the areas that your > other patches touch.
Unfortunately, Greg told him to split it like this. I also liked the single patch more. I wonder why [email protected] was not cc-ed on this series? Anyway, the cleanups are so trivial they should just be applied.... No need to spend huge time arguing. Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e _______________________________________________ Nbd-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/nbd-general
