On Thu, Jul 7, 2016 at 8:26 PM, Pranay Srivastava <[email protected]> wrote:
> On Thu, Jun 30, 2016 at 4:32 PM, Pranay Kr. Srivastava
> <[email protected]> wrote:
>> From: "Pranay Kr. Srivastava" <[email protected]>
>>
>> This patch
>> 1) uses spin_lock instead of irq version.
>>
>> 2) removes the goto statement in case a socket
>> is already assigned with simple if-else statement.
>>
>> Signed-off-by: Pranay Kr. Srivastava <[email protected]>
>> ---
>> drivers/block/nbd.c | 15 +++++----------
>> 1 file changed, 5 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
>> index 56f7f5d..766c401 100644
>> --- a/drivers/block/nbd.c
>> +++ b/drivers/block/nbd.c
>> @@ -643,17 +643,12 @@ static int nbd_set_socket(struct nbd_device *nbd,
>> struct socket *sock)
>> {
>> int ret = 0;
>>
>> - spin_lock_irq(&nbd->sock_lock);
>> -
>> - if (nbd->sock) {
>> + spin_lock(&nbd->sock_lock);
>> + if (nbd->sock)
>> ret = -EBUSY;
>> - goto out;
>> - }
>> -
>> - nbd->sock = sock;
>> -
>> -out:
>> - spin_unlock_irq(&nbd->sock_lock);
>> + else
>> + nbd->sock = sock;
>> + spin_unlock(&nbd->sock_lock);
>>
>> return ret;
>> }
>> --
>> 1.9.1
>>
>
> Hi Markus,
>
> Did you get a chance to review V4 of this series.
>
> --
> ---P.K.S
Ping ?
--
---P.K.S
------------------------------------------------------------------------------
Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
Francisco, CA to explore cutting-edge tech and listen to tech luminaries
present their vision of the future. This family event has something for
everyone, including kids. Get more information and register today.
http://sdm.link/attshape
_______________________________________________
Nbd-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/nbd-general
