I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]> Signed-off-by: Baole Ni <[email protected]> --- drivers/block/nbd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 6a48ed4..d30bff2 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -1128,7 +1128,7 @@ module_exit(nbd_cleanup); MODULE_DESCRIPTION("Network Block Device"); MODULE_LICENSE("GPL"); -module_param(nbds_max, int, 0444); +module_param(nbds_max, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(nbds_max, "number of network block devices to initialize (default: 16)"); -module_param(max_part, int, 0444); +module_param(max_part, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(max_part, "number of partitions per device (default: 0)"); -- 2.9.2 ------------------------------------------------------------------------------ _______________________________________________ Nbd-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/nbd-general
