-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102862/#review7437
-----------------------------------------------------------
I detected when you have a file tagged with Artist and Performer at the same
time both are indexed as composers. I think that the correct in this case is
treat Artist as Composer. This could be fixed with the next minor change:
<------------------>
if (!artist.empty()) {
if (!performer.empty()) {
artistField = factory->composerField;
--->>> performerField = factory->performerField;
}
else {
artistField = factory->performerField;
}
}
<------------------->
On the other side, maybe Lyricist and Author must be imported as composers.
- Ignacio Serantes
On Oct. 14, 2011, 2:05 p.m., Sebastian Trueg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102862/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2011, 2:05 p.m.)
>
>
> Review request for Nepomuk and Strigi.
>
>
> Description
> -------
>
> The Vorbis comment specs states:
>
> ARTIST: "The artist generally considered responsible for the work. In popular
> music this is usually the performing band or singer. For classical music it
> would be the composer. For an audio book it would be the author of the
> original text."
>
> PERFORMER: "The artist(s) who performed the work. In classical music this
> would be the conductor, orchestra, soloists. In an audio book it would be the
> actor who did the reading. In popular music this is typically the same as the
> ARTIST and is omitted."
>
> This patch tries to follow that suggestion by using nmm:performer and
> nmm:composer accordingly.
>
>
> Diffs
> -----
>
> lib/endanalyzers/flacendanalyzer.cpp ec885f6
> lib/throughanalyzers/oggthroughanalyzer.cpp d70f654
>
> Diff: http://git.reviewboard.kde.org/r/102862/diff/diff
>
>
> Testing
> -------
>
> Tried indexing ogg files. The result is correct.
>
>
> Thanks,
>
> Sebastian Trueg
>
>
_______________________________________________
Nepomuk mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/nepomuk
