----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103961/#review10582 -----------------------------------------------------------
Ship it! It looks good to me. I did not know about access() and realpath() yet, but using them should be fine. - Jos van den Oever On Feb. 13, 2012, 8:24 a.m., Sebastian Trueg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103961/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2012, 8:24 a.m.) > > > Review request for Nepomuk and Strigi. > > > Description > ------- > > The analyzer now constructs absolute paths to the containing files and > creates nie:links relations to them. nie:hasLogicalPart does not make much > sense since the audio files are not actually contained in the playlist, they > are just referenced. NFO specifies the usage of rdf:list. However, that is > not supported in Nepomuk at the moment. Thus, we cannot put any order on the > linked audio files yet. > > > Diffs > ----- > > lib/lineanalyzers/m3ustreamanalyzer.h 461def3 > lib/lineanalyzers/m3ustreamanalyzer.cpp dacc15a > > Diff: http://git.reviewboard.kde.org/r/103961/diff/ > > > Testing > ------- > > Tested via rdfindexer and nepomukindexer. The results are good. Absolute > paths in the m3u are not supported yet. But it is much better than before. > > > Thanks, > > Sebastian Trueg > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
