> On June 13, 2012, 8:25 p.m., Sebastian Trueg wrote: > > lib/endanalyzers/id3endanalyzer.cpp, line 524 > > <http://git.reviewboard.kde.org/r/105242/diff/1/?file=67582#file67582line524> > > > > Would it make sense to check the value or is ot ok to just allow any > > string to be the genre?
Any string because there are genres not in the list like K-Pop or Kpop. - Ignacio ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105242/#review14705 ----------------------------------------------------------- On June 14, 2012, 9:38 a.m., Ignacio Serantes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105242/ > ----------------------------------------------------------- > > (Updated June 14, 2012, 9:38 a.m.) > > > Review request for Nepomuk, Strigi and Vishesh Handa. > > > Description > ------- > > If genre is stored in a non numeric format genre is not imported. > > > Diffs > ----- > > lib/endanalyzers/id3endanalyzer.cpp d8487b5 > > Diff: http://git.reviewboard.kde.org/r/105242/diff/ > > > Testing > ------- > > Testing with and without a genre in string form. > > > Thanks, > > Ignacio Serantes > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
