> On June 15, 2012, 2:50 p.m., Sebastian Trueg wrote: > > I think this is correct. But I cannot remember exactly why I introduced the > > thread in the first place. So I am not entirely sure. But if you tested > > everything including automatic query updates then this should be fine. > > Actually I suppose we could improve the performance even more by not using > > the query service... > > Vishesh Handa wrote: > I'll test it more. I've checked out the BlueDevil code, and they do it in > the pretty much same way. > > Even I wanted to not use the QueryService, but we need query updates. > Maybe we could abstract away the query service stuff and just do it in the > query service?
Well, the query updates are done in the kded module anyway. The kio slave is not concerend with that. - Sebastian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105255/#review14761 ----------------------------------------------------------- On June 14, 2012, 11:28 p.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105255/ > ----------------------------------------------------------- > > (Updated June 14, 2012, 11:28 p.m.) > > > Review request for Nepomuk and Sebastian Trueg. > > > Description > ------- > > The extra QThread isn't really required and complicates the code, and also > adds an unnecessary overhead. > > > Diffs > ----- > > nepomuk/kioslaves/search/kio_nepomuksearch.h e68ff29 > nepomuk/kioslaves/search/kio_nepomuksearch.cpp 38894be > nepomuk/kioslaves/search/searchfolder.h c0839b5 > nepomuk/kioslaves/search/searchfolder.cpp 8088c46 > > Diff: http://git.reviewboard.kde.org/r/105255/diff/ > > > Testing > ------- > > Works exactly the same as before. > > > Thanks, > > Vishesh Handa > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
