On Sunday 08 July 2012 13:00:55 Volker Krause wrote: > On Sunday 08 July 2012 09:40:32 David Faure wrote: > > On Saturday 07 July 2012 11:13:08 Volker Krause wrote: > > > On Friday 06 July 2012 14:44:30 David Faure wrote: > > > > I found the reason for the kmail composer window being disabled > > > > forever, > > > > in > > > > some cases. > > > > > > > > A blocking nepomuk query from an akonadiserver thread never > > > > terminates, > > > > because nepomukqueryservice crashes meanwhile. > > > > > > > > This leads to two bugs: > > > > > > > > 1) queryserviceclient should kill blocking queries when > > > > _k_serviceUnregistered tells us the service crashed. > > > > The attached patch works for me, OK if I commit it to all appropriate > > > > branches? (kdelibs 4.8, kdelibs 4.9, nepomuk-core, akonadi master -- > > > > LOL) > > > > > > +1 as far as Akonadi is concerned. We don't have _k_serviceUnregistered > > > at > > > all though, so this might require backporting a few more changes of the > > > queryserviceclient code. > > > > Yep, I have these commits ready for akonadi. Just waiting for an OK from > > the nepomuk side. > > great > > > BTW, does search/nepomuksearchengine.cpp ever delete QueryServiceClient > > instances? It seems to me that reloadSearches() leaks all the > > already-running queries. > > reloadSearches() calls removeSearch() for all existing QueryServiceClients, > which ends with a call to deleteLater(), so this looks ok to me.
My bad, I was looking for "delete " so I missed the deleteLater call. -- David Faure, [email protected], http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5 _______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
