> On June 19, 2012, 4:46 a.m., Sebastian Trueg wrote: > > libnepomukcore/query/resultiterator.h, line 32 > > <http://git.reviewboard.kde.org/r/105287/diff/1/?file=68203#file68203line32> > > > > I think QueryIterator would be a better name. > > Vishesh Handa wrote: > Well, I thought it was a little bit too much - Query::QueryIterator. And > it's iterating over a query's results, and not the actual query. Plus, that's > the name we decided on during the Frameworks meetings. > > > http://community.kde.org/Projects/Nepomuk/Irc_meeting_nepomuk_frameworks#Queries
OK. > On June 19, 2012, 4:46 a.m., Sebastian Trueg wrote: > > libnepomukcore/query/resultiterator.h, line 35 > > <http://git.reviewboard.kde.org/r/105287/diff/1/?file=68203#file68203line35> > > > > I think thanks to additionalBindings the reqpropmap is rather > > deprecated. > > Vishesh Handa wrote: > Well, I'm not sure, but I was under the impression that request > properties now overshadowed the additional bindings. Is it the other way > around? In either case, we should act fast cause we can break binary > compatibility before 4.9 is released. reqprops are actually implemented using additional bindings with special name prefixes. But since they are much easier to understand than additional bindings I am fine with keeping them. - Sebastian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105287/#review14872 ----------------------------------------------------------- On July 11, 2012, 3:38 p.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105287/ > ----------------------------------------------------------- > > (Updated July 11, 2012, 3:38 p.m.) > > > Review request for Nepomuk. > > > Description > ------- > > Allow synchronous execution of queries > > This is done by returning a Nepomuk::Query::ResultIterator, and > allows the user to control the execution of the query with the > iterator. > > This lets us move away from Soprano. Plus, this avoids > code duplication as this code is being duplicated in both the > query service and the kioslave. > > > Diffs > ----- > > includes/CMakeLists.txt 3e07f83 > includes/Query/ResultIterator PRE-CREATION > libnepomukcore/CMakeLists.txt 066c898 > libnepomukcore/query/resultiterator.h PRE-CREATION > libnepomukcore/query/resultiterator.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/105287/diff/ > > > Testing > ------- > > > Thanks, > > Vishesh Handa > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
