----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105517/ -----------------------------------------------------------
(Updated July 15, 2012, 8:44 p.m.) Review request for Nepomuk and Sebastian Trueg. Changes ------- Someone should improve post-review. Uploaded the correct patch, manually. Description ------- Remove special handling for rdf:type This includes storing the maintype when loading all the properties. This simplifies the code base, and actually improves performace. Because the type deduction is done during load time, the relevant types needed to be loaded into memory by Types::EntityPrivate, this increases the load time for each resource by an order of 5x. This extra load eventually goes down when all the required types are loaded, but it's there. Also, the additional cost of infering the type each time doesn't seem to have any performance loss. Mainly cause everything is already in memory. Another reason for this patch is the planned refactoring of the class internals to use shared memory. Every extra variable in ResourceData adds an overhead. Diffs (updated) ----- libnepomukcore/resource/resource.cpp c237f44 libnepomukcore/resource/resourcedata.h 3708897 libnepomukcore/resource/resourcedata.cpp 6fa262f Diff: http://git.reviewboard.kde.org/r/105517/diff/ Testing ------- Manual + Unit Testing :) Thanks, Vishesh Handa
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
