----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105562/#review16360 -----------------------------------------------------------
libnepomukcore/resource/resource.cpp <http://git.reviewboard.kde.org/r/105562/#comment12832> What if at this point newData is deleted by another thread? That could happen if the other Resource referring to newData was deleted since the ref counter in newData has not been increased yet. - Sebastian Trueg On July 13, 2012, 9:24 p.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105562/ > ----------------------------------------------------------- > > (Updated July 13, 2012, 9:24 p.m.) > > > Review request for Nepomuk, Vishesh Handa and Sebastian Trueg. > > > Description > ------- > > Fix race conditions in nepomuk's ResourceData. > > Found with "helgrind kmail --nofork", inbox, clicking on any email. > where helgrind is "QT_NO_GLIB=1 valgrind --tool=helgrind > --track-lockorders=no" > > The change in resource.cpp avoids a deadlock due to the change > in resourcedata: no need to hold the rmMutex for the determineUri call. > > > Diffs > ----- > > libnepomukcore/resource/resource.cpp > c237f44c1420929143299aab391a0f2a7709f894 > libnepomukcore/resource/resourcedata.cpp > e19b4bdcd3bea11c32673d13df665cff24783e06 > > Diff: http://git.reviewboard.kde.org/r/105562/diff/ > > > Testing > ------- > > > Thanks, > > David Faure > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
