> On July 17, 2012, 10:28 p.m., Simeon Bird wrote: > > Ship It! > > Simeon Bird wrote: > I updated the patch with a big comment. Thanks for reviewing! > > Can it get into some 4.9 point release, or does it wait until 4.10? > > Vishesh Handa wrote: > Please commit it in both master and 4.9 > > Simeon Bird wrote: > I don't think I have commit rights. > > Vishesh Handa wrote: > Hey Simeon. Thanks a lot for the patch. > > Also, I suggest that you get a developer account, if you plan to continue > contributing to KDE (which I hope you do). You can add me the referral. > > If you want, I can point you to some Nepomuk tasks that I could use some > help with? > > Simeon Bird wrote: > Thanks Vishesh! > > Go ahead and email me with the nepomuk tasks you mention - sounds like > fun. > I'll also request a developer account at some point. > I can't promise any particularly well-defined latency, but I'll see what > I can do.
Sure. Take your time. This is meant to be fun :) I made a blog post about it a little while back - http://vhanda.in/blog/2012/07/opening-up-nepomuk-development/ . And here is the entire list from bugzilla - https://bugs.kde.org/buglist.cgi?list_id=157799&bug_severity=task&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&product=nepomuk%7C . I'm looking forward to your patches :) - Vishesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105158/#review16045 ----------------------------------------------------------- On July 17, 2012, 10:28 p.m., Simeon Bird wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105158/ > ----------------------------------------------------------- > > (Updated July 17, 2012, 10:28 p.m.) > > > Review request for Dolphin, Nepomuk, Peter Penz, and Sebastian Trueg. > > > Description > ------- > > This patch attempts to fix bug 293111. > > The problem is that the nepomuk kioslave gives files a targetUrl > understandable by non-KDE applications (ie, their real path on the > filesystem). > > However, it does not give this to directories, and it only does the fancy > stuff on the query folder, not any subfolders. The subfolders are opened with > the kioslave base listdir class. The easy way to fix this is to set > UDS_TARGET_URL for director a "real" url, which is what the attached patch > does. > > > This addresses bug 293111. > http://bugs.kde.org/show_bug.cgi?id=293111 > > > Diffs > ----- > > nepomuk/kioslaves/search/searchfolder.cpp e8c8369 > > Diff: http://git.reviewboard.kde.org/r/105158/diff/ > > > Testing > ------- > > I compiled and ran it on my machine with some search results. Not tested on > search results that are not local files. > > > Thanks, > > Simeon Bird > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
