----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105872/#review16891 -----------------------------------------------------------
Nice work! I'm not sure about the last point - "Speed up searchRunnable.run() by storing up to 10 results in the result list before sending them to folder.addResults(). This should be faster by needing less locking overhead. I haven't actually timed it, so it may be marginal." I've actually tried this before, and seen no actual performance benefit. Without actual benchmarks, I'm not sure I would like to have this. Anyway, could you please split the last point in another patch? (Try a git add -p, it's awesome!) services/queryservice/searchrunnable.cpp <http://git.reviewboard.kde.org/r/105872/#comment13229> Loose the Nepomuk2:: if possible. It's unnecessary. - Vishesh Handa On Aug. 5, 2012, 6:08 a.m., Simeon Bird wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105872/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2012, 6:08 a.m.) > > > Review request for Nepomuk, Vishesh Handa and Sebastian Trueg. > > > Description > ------- > > This is a fairly trivial patch to port the QueryService to the > Query::ResultIterator; just doing something quick to get my hand in. > > - Changes ResourceManager::mainModel() use in QueryService to ResourceIterator > - Removes now unneeded includes, functions, etc > - Speed up searchRunnable.run() by storing up to 10 results in the result > list before sending them to folder.addResults(). This should be faster by > needing less locking overhead. I haven't actually timed it, so it may be > marginal. > > > This addresses bug 303383. > http://bugs.kde.org/show_bug.cgi?id=303383 > > > Diffs > ----- > > services/queryservice/searchrunnable.h 1c12a9b > services/queryservice/searchrunnable.cpp 451db46 > > Diff: http://git.reviewboard.kde.org/r/105872/diff/ > > > Testing > ------- > > Compiles, dolphin search still works. > > > Thanks, > > Simeon Bird > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
