----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106320/#review18498 -----------------------------------------------------------
Actually I would use ResourceManagerWatcher::getTypes() in ResourceManagerWatcher::removeResource if "types" is empty. It reuses existing code. All that is left then is to move the removeResource call as you already did. - Sebastian Trueg On Sept. 4, 2012, 12:11 p.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106320/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2012, 12:11 p.m.) > > > Review request for Nepomuk and Sebastian Trueg. > > > Description > ------- > > Inform the ResourceWatcherManager that the resources have been removed, > along with their respective types. > > This requires additional querying in order to determine the type, but we > need it so there is no way around it. > > > Diffs > ----- > > services/storage/datamanagementmodel.cpp 69c046d > > Diff: http://git.reviewboard.kde.org/r/106320/diff/ > > > Testing > ------- > > > Thanks, > > Vishesh Handa > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
