> On Sept. 4, 2012, 1:21 p.m., Sebastian Trueg wrote: > > services/storage/datamanagementmodel.cpp, line 1937 > > <http://git.reviewboard.kde.org/r/106324/diff/2/?file=83493#file83493line1937> > > > > Do you really remove the oldValue? > > Vishesh Handa wrote: > It's useful to update the Resource cache. Plus, merge resource isn't a > function that would be called that often, so the performance doesn't matter > that much. > > Sebastian Trueg wrote: > I was actually asking if this is correct since the last parameter of > changeProperty is the removed values. > > Vishesh Handa wrote: > I think so, we basically changing all - > > ?r ?p <one-of-the-resoruces-to-be-merged> into ?r ?p > <first-resource-in-the-merge-resources-list>. > > The "<one-of-the-resoruces-to-be-merged>" will be removed when it is > deleted, and resUri is added. > > Sebastian Trueg wrote: > Ah, I see. Then clients will get that information twice, wont they? The > second time when the resource is actually removed?
Actually yes. But it's good to get it twice, cause it makes our job easier. When a resource is deleted we don't want to have to search through all the properties in every resource in the resourcemanager to see if some resource has a property which mentions it. - Vishesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106324/#review18500 ----------------------------------------------------------- On Sept. 4, 2012, 12:18 p.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106324/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2012, 12:18 p.m.) > > > Review request for Nepomuk and Sebastian Trueg. > > > Description > ------- > > We should inform the Resource Watcher Manager when merging resources, so > that it can inform the interested parties. > > Also added a unit test to check if the signals are being emitted. > > > Diffs > ----- > > services/storage/datamanagementmodel.cpp 69c046d > services/storage/test/qtest_dms.cpp cc4ed07 > services/storage/test/resourcewatchertest.cpp 8a38a9c > > Diff: http://git.reviewboard.kde.org/r/106324/diff/ > > > Testing > ------- > > > Thanks, > > Vishesh Handa > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
